Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove operation and service labels from Nexus schedule to start metric #1830

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Remove operation and service labels from Nexus schedule to start metric #1830

merged 3 commits into from
Feb 18, 2025

Conversation

bergundy
Copy link
Member

The labels are not relevant when polling from the Nexus task queue where any request (task) may be served.

@bergundy bergundy requested a review from a team as a code owner February 18, 2025 17:46
Quinn-With-Two-Ns
Quinn-With-Two-Ns reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully some test would need to be updated based on the tags changing?

@bergundy
Copy link
Member Author

Just fixed the tests.

@bergundy bergundy enabled auto-merge (squash) February 18, 2025 21:02
@bergundy bergundy merged commit 8f38795 into temporalio:master Feb 18, 2025
13 checks passed
@bergundy bergundy deleted the nexus-sched-to-start-label-fix branch February 19, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bergundy @Quinn-With-Two-Ns