Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Temporal-Namespace header on every namespace-specific gRPC request #1467

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Set Temporal-Namespace header on every namespace-specific gRPC request #1467

merged 5 commits into from
Feb 4, 2025

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Set Temporal-Namespace header on every namespace-specific gRPC request.

closes #1458

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner May 11, 2024 20:05
cretz
cretz approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still approved. We should consider, as a separate issue, tests in every SDK that use data plane in cloud with API key to confirm this works.

@cretz cretz mentioned this pull request Feb 4, 2025
Merged
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 24542f7 into temporalio:master Feb 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set Temporal-Namespace header on every namespace-specific gRPC request
2 participants
@Quinn-With-Two-Ns @cretz