Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch github runner to macos-14 (m1) #1421

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Switch github runner to macos-14 (m1). Currently macos-latest runs on macos-12 on intel. Reading some docs at some point github will change macos-latest to point at macos-14, but we can update our CI sooner.

https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/

@Quinn-With-Two-Ns
Copy link
Contributor Author

We could also keep macos-12 as a runner if we want mac+intel coverage

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review March 12, 2024 22:50
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner March 12, 2024 22:50
@cretz
Copy link
Member

cretz commented Mar 13, 2024

We could also keep macos-12 as a runner if we want mac+intel coverage

Question: Will macos x64 continue to be supported by GH in the future, or must we fixate on an old version? Reading around, macos 14 supports intel processors, does GH just not offer it?

@Quinn-With-Two-Ns
Copy link
Contributor Author

Will macos x64 continue to be supported by GH in the future, or must we fixate on an old version?Will macos x64 continue to be supported by GH in the future, or must we fixate on an old version?

Reading some announcement post they have no plans to add new x64 macos runners

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 3da09e0 into temporalio:master Mar 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants