Add Nexus tracing interceptor (#1844)

temporalio · Feb 25, 2025 · f3da1f5 · f3da1f5
1 parent ab1c356
commit f3da1f5
Show file tree

Hide file tree

Showing 6 changed files with 382 additions and 43 deletions.
diff --git a/contrib/opentelemetry/tracing_interceptor.go b/contrib/opentelemetry/tracing_interceptor.go
@@ -148,6 +148,11 @@ func (t *tracer) Options() interceptor.TracerOptions {
 }
 
 func (t *tracer) UnmarshalSpan(m map[string]string) (interceptor.TracerSpanRef, error) {
+	if _, ok := m["traceparent"]; !ok {
+		// If there is no span, return nothing, but don't error out. This is
+		// a legitimate place where a span does not exist in the headers
+		return nil, nil
+	}
 	ctx := t.options.TextMapPropagator.Extract(context.Background(), textMapCarrier(m))
 	spanCtx := trace.SpanContextFromContext(ctx)
 	if !spanCtx.IsValid() {

diff --git a/contrib/opentracing/interceptor.go b/contrib/opentracing/interceptor.go
@@ -25,6 +25,7 @@ package opentracing
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"github.com/opentracing/opentracing-go"
@@ -111,6 +112,11 @@ func (t *tracer) Options() interceptor.TracerOptions {
 
 func (t *tracer) UnmarshalSpan(m map[string]string) (interceptor.TracerSpanRef, error) {
 	ctx, err := t.options.Tracer.Extract(opentracing.TextMap, opentracing.TextMapCarrier(m))
+	if errors.Is(err, opentracing.ErrSpanContextNotFound) {
+		// If there is no span, return nothing, but don't error out. This is
+		// a legitimate place where a span does not exist in the headers
+		return nil, nil
+	}
 	if err != nil {
 		return nil, err
 	}