Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting #3360

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Fix formatting #3360

merged 3 commits into from
Feb 19, 2025

Conversation

dandavison
Copy link
Contributor

WISOTT.

Viewing the PR with whitespace changes hidden shows that there are no non-whitespace changes.

@dandavison dandavison requested a review from a team as a code owner February 18, 2025 19:10
@jsundai jsundai self-requested a review February 18, 2025 19:25
@jsundai
Copy link
Contributor

jsundai commented Feb 19, 2025

Thanks for the contribution, @dandavison. 🙌 Looks like when I run yarn format, it doesn't like the decode format and moves it back. Other than that, LGTM.

@jsundai jsundai merged commit 9f3c341 into main Feb 19, 2025
4 checks passed
@jsundai jsundai deleted the fix-python-converter-formatting branch February 19, 2025 23:32
@dandavison
Copy link
Contributor Author

Thanks!

Looks like when I run yarn format, it doesn't like the decode format and moves it back. Other than that, LGTM.

Hm, that's a bit unfortunate, since it should really "pair up" with the encode method above it. Maybe just combine them into a single code block as in this PR: #3371

@axfelix
Copy link
Contributor

axfelix commented Feb 20, 2025

@dandavison Yeah, I can see the issue here, but you can probably see why dprint behaves that way -- it wants to dedent any given sample it sees, it can't really carry forward indentation level from one sample to the next (that would bake in some strange expectations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants