Use server's timestamp.ParseDuration for all durations #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeebswihart
approved these changes
May 20, 2024
dnr
commented
May 21, 2024
| @@ -335,6 +336,10 @@ func (c *CommandOption) writeFlagBuilding(selfVar, flagVar string, w *codeWriter | |||
| desc += fmt.Sprintf(" Accepted values: %s.", strings.Join(c.EnumValues, ", ")) | |||
| } | |||
|
|
|||
| if setDefault != "" { | |||
| // set default before calling Var so that it stores thedefault value into the flag | |||
| w.writeLinef("%v.%v = %v", selfVar, c.fieldName(), setDefault) | |||
There was a problem hiding this comment.
@cretz If this isn't the right way to do defaults for Var flags, let me know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Use server
timestamp.ParseDurationfor parsing durations in flags. This supports adsuffix for multiples of 24 hours.Why?
Convenience and compatibility.
Checklist
Modified namespace test and checked --help output manually