New Deployment protos to work with already-implemented versioning 3 API's #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jan 15, 2025
There was a problem hiding this comment.
The aim of this PR is to update those protos which are required by the deployment entity workflows so that work on those can commence there ASAP.
Can we hold off on merging to master until that work is done? I am assuming there is no user-facing need for this imminently?
temporal/api/.idea/workspace.xml
Outdated
There was a problem hiding this comment.
I don't think this file needs to be committed
There was a problem hiding this comment.
oops, sorry - shall remove this.
Yes, we can hold off until Shahab's PR gets in.
ShahabT
reviewed
Jan 16, 2025
ShahabT
reviewed
Jan 16, 2025
| // Sets a deployment version as the current version for its deployment. | ||
| rpc SetCurrentDeploymentVersion (SetCurrentDeploymentVersionRequest) returns (SetCurrentDeploymentVersionResponse) { | ||
| option (google.api.http) = { | ||
| post: "/namespaces/{namespace}/current-deployment-version/{deployment_name}" |
There was a problem hiding this comment.
Suggested change
| post: "/namespaces/{namespace}/current-deployment-version/{deployment_name}" | |
| post: "/namespaces/{namespace}/worker-deployment/{deployment_name}/set-current-version" |
Co-authored-by: Shahab Tajik <[email protected]>
|
Yes, thanks! I can apply much less stability scrutiny to non- |
cretz
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.
What changed?
Deployment->WorkerDeploymentVersionNote: This API does not update pre-release versioning-3 changes related to dataplane. That currently is being worked in separate PR. The aim of this PR is to update those protos which are required by the deployment entity workflows so that work on those can commence there ASAP.
Additionally, the updates to the proto are not finalized and will bring in more additions. Right now, they contain the bare minimum fields/structs required to make the deployment entity workflows run.
With that being said, care has been taken to not add fields here and delete them in the near future. In other words, future changes will only bring in additions to these new protos.
Why?
Breaking changes
Server PR