Add capabilities field to RespondWorkflowTaskCompletedResponse #458
Conversation
| // | ||
| // (-- api-linter: core::0140::prepositions=disabled | ||
| // aip.dev/not-precedent: "with" used to describe the workflow task. --) | ||
| bool discard_speculative_workflow_task_with_command_events = 1; |
There was a problem hiding this comment.
| bool discard_speculative_workflow_task_with_command_events = 1; | |
| bool discard_speculative_workflow_task_with_events = 1; |
command_events is not a common well known name. And in fact, all events falls in this category. Let's say we enable signal without WFT one day.
There was a problem hiding this comment.
We use "command_events" in the SDKs all over the place to refer to the events corresponding to commands. So, not all events are that - like signaled events.
There was a problem hiding this comment.
Yeah command_events is a common term in the SDK
There was a problem hiding this comment.
that being said I am not opposed to removing it
Yes, all latest SDK now do. but old versions didn't |
I would maybe consider hard coding these SDK versions on the server instead of adding this mechanism since it's easy enough for us to track those but I'm okay adding it if people see this useful beyond the single use case. |
@Quinn-With-Two-Ns - what happens to older SDKs if the server were to just behave as if this new field was always true? Are all SDKs that don't work with this part of update pre-release instead of public preview? Just trying to help justify a new permanent proto field just for pre-release update SDKs. |
The history will be corrupted , we have already had multiple meetings and a design doc to converage on this solution |
…rd_speculative_workflow_task_with_events
Quinn-With-Two-Ns
force-pushed
the
SDK-2875
branch
from
ccd8b4e to
5ff6483
Compare
Add capabilities field to RespondWorkflowTaskCompletedResponse. Add
may_discard_speculative_workflowtask_with_command_eventsthat will allow the SDK to signal to the Server that it supports discarding speculative workflow tasks with command events. When this is set to true it will allow the server to discard a lot more speculative workflow tasks then it can today.