-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Worker versioning related updates #272
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,12 +87,9 @@ message StickyExecutionAttributes { | |
google.protobuf.Duration schedule_to_start_timeout = 2 [(gogoproto.stdduration) = true]; | ||
} | ||
|
||
// Used by the worker versioning APIs, represents an ordering of one or more versions which are | ||
// considered to be compatible with each other. Currently the versions are always worker build ids. | ||
// Used by the worker versioning APIs, represents an unordered set of one or more versions which are | ||
// considered to be compatible with each other. Currently the versions are always worker build IDs. | ||
message CompatibleVersionSet { | ||
// A unique identifier for this version set. Users don't need to understand or care about this | ||
// value, but it has value for debugging purposes. | ||
string version_set_id = 1; | ||
// All the compatible versions, ordered from oldest to newest | ||
repeated string build_ids = 2; | ||
// All the compatible versions, unordered, except for the last element, which is considered the set "default". | ||
repeated string build_ids = 1; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it safe to change the id from 2 to 1? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This API isn't in use yet There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not in general, but this is not in use anywhere yet |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I would think this flag should not be part of the stamp itself, but part of the requests that include a stamp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point.