Skip to content

Commit

Permalink
Minor renames/comment adjust
Browse files Browse the repository at this point in the history
  • Loading branch information
Sushisource committed Sep 28, 2022
1 parent e219a57 commit 0cced3e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion temporal/api/history/v1/message.proto
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ message WorkflowTaskCompletedEventAttributes {
// Version info of the worker who processed this workflow task, or missing if worker is not
// using versioning. If present, the `build_id` field within supersedes `binary_checksum`, which
// may be populated with the same value to preserve compatability.
temporal.api.common.v1.WorkerVersionStamp worker_versions = 5;
temporal.api.common.v1.WorkerVersionStamp worker_version = 5;
}

message WorkflowTaskTimedOutEventAttributes {
Expand Down
12 changes: 6 additions & 6 deletions temporal/api/workflowservice/v1/request_response.proto
Original file line number Diff line number Diff line change
Expand Up @@ -293,10 +293,9 @@ message RespondWorkflowTaskCompletedRequest {
map<string, temporal.api.query.v1.WorkflowQueryResult> query_results = 8;
string namespace = 9;
// If using versioning, the worker uses this field to indicate what version(s) it used to
// process the task.
// When this field has a `worker_build_id`, and `binary_checksum` is not set, that value should
// also be considered as the `binary_checksum`.
temporal.api.common.v1.WorkerVersionStamp worker_versions_stamp = 10;
// process the task. When this field has a `worker_build_id`, and `binary_checksum` is not set,
// that value should also be considered as the `binary_checksum`.
temporal.api.common.v1.WorkerVersionStamp worker_version_stamp = 10;
}

message RespondWorkflowTaskCompletedResponse {
Expand Down Expand Up @@ -1026,8 +1025,9 @@ message UpdateWorkerBuildIdOrderingRequest {
string task_queue = 2;
oneof operation {
// An id for a new version. This operation will create a new set which will be the new
// overall default version for the queue, with this version as its only member.
string new_default_major_version_id = 3;
// overall default version for the queue, with this version as its only member. This new
// set is incompatible with all previous sets/versions.
string new_default_version_id = 3;
// Adds a new id to an existing compatible set, see sub-message definition for more.
NewCompatibleVersion new_compatible_version = 4;
// Promote an existing set to be the current default (if it isn't already) by targeting
Expand Down

0 comments on commit 0cced3e

Please sign in to comment.