This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Add internal ability to change API url #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, telegram has published [Telegram Bot API Server] - HTTP API <-> MTPROTO proxy which is used internally by telegram. Now it's possible to run the server locally. However currently it's not possible to use teloxide with such local server, because API url is hardcoded into teloxide. This commit makes _internall_ changes to allow setting the API url. It doesn't yet allow to set the url from user code (i.e.: no changes in public API), in my opinion such additions are blocked on some bot refactorings. `Bot::api_url` is made `Option<Arc<str>>` to minimize costs in case of 'default url' (probably the most common case). Progress of this issue is tracked in teloxide/teloxide#317 [Telegram Bot API Server]: https://github.com/tdlib/telegram-bot-api
|
@WaffleLapkin I think that api_url must be Arc, not Option, because there are must be an url anyway. It may be defined when Bot is creating: if user specified the url, than use it, or use default. It will simplify implementation of request_* methods and make code more clear. |
There is no need for allocating and cloning the |
hirrolot
reviewed
Nov 17, 2020
Add `ApiUrl` and also use `Url` instead of `&str` for urls to clean code
hirrolot
approved these changes
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, telegram has published Telegram Bot API Server - HTTP API <->
MTPROTO proxy which is used internally by telegram. Now it's possible to run
the server locally.
However currently it's not possible to use teloxide with such local server,
because API url is hardcoded into teloxide.
This commit makes internall changes to allow setting the API url. It doesn't
yet allow to set the url from user code (i.e.: no changes in public API), in my
opinion such additions are blocked on some bot refactorings.
Bot::api_urlis madeOption<Arc<str>>to minimize costs in case of 'defaulturl' (probably the most common case).
Progress of this issue is tracked in teloxide/teloxide#317