Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new kb article grid-kb-conditionally-hide-command-buttons #2718

Conversation

kendo-bot
Copy link
Collaborator

No description provided.

@kendo-bot kendo-bot requested a review from a team as a code owner January 21, 2025 15:26
@xristianstefanov xristianstefanov self-assigned this Jan 21, 2025
@xristianstefanov xristianstefanov added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Jan 21, 2025
Copy link
Contributor

Hello @xristianstefanov,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

Copy link
Contributor

@Tsvetomir-Hr Tsvetomir-Hr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use slug instead of links and rename file name to grid-conditionally-hide-command-buttons.md

Comment on lines +75 to +78
private async Task HandleCustomButtonClick(GridCommandEventArgs args)
{
CustomCommandResult = new MarkupString(CustomCommandResult + string.Format("<br />Custom command triggered for item {0}", (args.Item as SampleData).ID));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified or even removed. The focus of the KB is different and doesn't require MarkupString or custom commands. You can use a built-in Delete command.

Copy link
Contributor

@xristianstefanov xristianstefanov Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let that be the difference from the Incell editing demo?

@dimodi dimodi merged commit e0fa75d into master Jan 23, 2025
Copy link
Contributor

Here you are the link to your PR to production: 2725

@github-actions github-actions bot deleted the new-kb-grid-kb-conditionally-hide-command-buttons-cf7bcd9c885547e5be5bc421dec101cc branch January 23, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants