Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update with FalcoSidekickURL case #163

Merged

Conversation

dwisiswant0
Copy link
Collaborator

IMPORTANT: Please do not create a PR without creating an issue first!

(Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request).

Summary

update with FalcoSidekickURL case also adds with invalid case

Proposed of changes

This PR fixes/implements the following bugs/features:

  • update with FalcoSidekickURL case also adds with invalid case

How has this been tested?

Proof:

Closing issues

Fixes #

Checklist:

  • My code follows the code style of this project.
  • My changes successfully ran and pass linters locally (run make lint).
  • I have written new tests for my changes.
    • My changes successfully ran and pass tests locally.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

also adds with invalid case

Signed-off-by: Dwi Siswanto <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.45%. Comparing base (d469b5d) to head (8d93dc7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   80.46%   81.45%   +0.99%     
==========================================
  Files          15       15              
  Lines         906      906              
==========================================
+ Hits          729      738       +9     
+ Misses        115      110       -5     
+ Partials       62       58       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwisiswant0 dwisiswant0 merged commit b2aee2a into master Feb 25, 2024
17 checks passed
@dwisiswant0 dwisiswant0 deleted the dwisiswant0/test/update-with-falcosidekickurl-case branch February 25, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants