Let telepresence connect despite DNS failure. #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users benefit from having the routing up and running even though DNS isn't working. This commit ensures that `telepresence connect` succeeds even though the DNS server configuration was unsuccessful but a warning is printed on stderr, informing the user that the DNS isn't functional. A call to `telepresence status` will also show the DNS error. Signed-off-by: Thomas Hallgren <[email protected]>
The global DNS search path can be set, either by using Powershell or directly, by setting a registry value. Using Powershell will sometimes fail due to group policies and setting the registry value doesn't seem to work on all Windows platforms. This commit introduces a strategy setting that can be set to "auto", "powershell", or "registry" where "auto" means that "powershell" is tried first, and if it fails, fallback to "registry". The default setting is "auto". Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
This was
linked to
issues
Apr 29, 2023
thallgren
changed the title
thallgren
requested review from
a team and
josecv
and removed request for
a team
Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
josecv
approved these changes
May 1, 2023
Signed-off-by: Thomas Hallgren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the functionality requested in ticket #3152.
telepresence connectwill succeed even if the DNS isn't functional.network.globalDNSSearchConfigStrategywhich can be set toauto(the default),powershell, orregistry.Checklist
./CHANGELOG.md.DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently.TELEMETRY.mdif I added, changed, or removed a metric name.