Fix unchecked cast panic in traffic-manager pod watcher. #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A watcher isn't guaranteed to always receive an object of the watched type. The `DeleteFunc` in particular, can receive an instance of `cache.DeleteFinalStateUnknown`. This commit ensures that the traffic- manager's node and pod watcher uses checked casts only and that the `cache.DeleteFinalStateUnknown` is handled properly. Closes #3149 Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
thallgren
requested review from
a team and
njayp
and removed request for
a team
njayp
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A watcher isn't guaranteed to always receive an object of the watched type. The
DeleteFuncin particular, can receive an instance ofcache.DeleteFinalStateUnknown. This commit ensures that the traffic-manager's node and pod watcher uses checked casts only and that thecache.DeleteFinalStateUnknownis handled properly.Closes #3149
Checklist
./CHANGELOG.md.DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently.TELEMETRY.mdif I added, changed, or removed a metric name.