Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aurelia mdc components #429

Conversation

selinanatschke-mms
Copy link
Collaborator

@selinanatschke-mms selinanatschke-mms commented May 28, 2024

Description

  • the aurelia mdc components have not been updated in a while
  • the newest Version for Aurelia 1 that is currently available is v9.0.8
    • the only thing that caused some tests to fail was the mdc-dialog which now requires tags explicitly

Note:

  • other than the material design components i looked into other aurelia dependencies that could be updated
  • the newest version of the aurelia-bootstrapper (2.4.0) caused the following error:
    image
    which is why we keep using the current version (2.3.3)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

sena added 6 commits May 28, 2024 10:17
@selinanatschke-mms selinanatschke-mms marked this pull request as ready for review May 30, 2024 07:18
@martingrossmann
Copy link
Contributor

@selinanatschke-mms Please also update the layout check dialog. Maybe the same change as for the screenshot dialog.

@selinanatschke-mms selinanatschke-mms marked this pull request as draft June 3, 2024 06:01
@selinanatschke-mms selinanatschke-mms marked this pull request as ready for review June 3, 2024 06:40
@martingrossmann martingrossmann merged commit 25ad8fd into telekom:master Jun 3, 2024
@selinanatschke-mms selinanatschke-mms deleted the update_aurelia_mdc_components branch June 3, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants