Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/element check timeout #414

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

TobiasAdler
Copy link
Collaborator

@TobiasAdler TobiasAdler commented Apr 9, 2024

Description

If there were multiple UiElements with a @Check and a custom timeout for that check, only the first element was checked with that timeout, because after that, the threadLocalTimeout was set to the tt.element.timeout.seconds property, even though there should be no threadLocalTimeout.

Example:

Property set: tt.element.timeout.seconds=10

@Check(checkRule = CheckRule.IS_NOT_DISPLAYED, timeout = 1)
private final UiElement test = find(By.id("test"));
// -> check was done with a timeout of 1 seconds

@Check(checkRule = CheckRule.IS_NOT_DISPLAYED, timeout = 1)
private final UiElement test2 = find(By.id("test2"));
// -> check was done with a timeout of 10 seconds

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@martingrossmann martingrossmann merged commit 959db0a into master Apr 10, 2024
@martingrossmann martingrossmann deleted the fix/element_check_timeout branch April 10, 2024 05:54
@martingrossmann martingrossmann added this to the 2.8 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants