Add video tab #407
Merged
Add video tab #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selinanatschke-mms
requested review from
mreiche,
martingrossmann,
gogro,
mbeuthan and
wolamms
as code owners
mreiche
previously approved these changes
Mar 25, 2024
martingrossmann
requested changes
Mar 27, 2024
mreiche
requested changes
Mar 27, 2024
mreiche
previously approved these changes
Apr 2, 2024
|
Looks great for me. But please fix the report test |
added 3 commits
April 16, 2024 11:22
# Conflicts: # docs/src/images/report-ng-23.png
martingrossmann
requested changes
Apr 23, 2024
added 2 commits
April 25, 2024 10:00
mreiche
previously approved these changes
Apr 30, 2024
| } | ||
|
|
||
| public void checkSessionId(String id){ | ||
| this.id.assertThat().text().contains(id); |
There was a problem hiding this comment.
Use isContaining() or contains(id).is(true)
| } | ||
|
|
||
| public void validateBrowser(String browser) { | ||
| this.browser.assertThat().text().contains(browser); |
There was a problem hiding this comment.
Use isContaining() or contains(id).is(true)
| } | ||
|
|
||
| public void checkSessionId(){ | ||
| this.id.assertThat().displayed(); |
There was a problem hiding this comment.
Like discussed this check is duplicated. If you want to check the ID, you should take it from Browser info.
martingrossmann
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Please delete options that are not relevant.
Checklist: