Refactor stringassertion #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change since the methods from QuantityAssertion are not available to StringAssertion anymore. An extra layer has been added with ObjectAssertion to capture methods that were used in both interfaces.
sbke-mms
requested review from
mreiche,
martingrossmann,
gogro,
mbeuthan and
wolamms
as code owners
core/src/main/java/eu/tsystems/mms/tic/testframework/internal/asserts/ObjectAssertion.java
Show resolved
Hide resolved
...src/main/java/eu/tsystems/mms/tic/testframework/internal/asserts/DefaultObjectAssertion.java
Show resolved
Hide resolved
| @@ -110,7 +111,7 @@ public BinaryAssertion<Boolean> hasWords(List<String> words) { | |||
| .collect(Collectors.joining("|")); | |||
| final Pattern wordsPattern = Pattern.compile(wordsList, Pattern.CASE_INSENSITIVE | Pattern.MULTILINE); | |||
|
|
|||
| final String wordsListWithoutRegex = String.join("|", words); | |||
| final String wordsListWithoutRegex = java.lang.String.join("|", words); | |||
There was a problem hiding this comment.
Why java.lang is used here?
martingrossmann
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The StringAssertion interface is no longer inheriting from QuantityAssertion instead both of those interfaces now inherit ObjectAssertion which inherits BinaryAssertion. Also StringAssertion is now restricted to the type String. This is a breaking change since StringAssertion previously was able to use the functions of QuantityAssertion. Since these only worked on numbers this didn't make sense and triggered this change.
These functions moved from QuantityAssertion to ObjectAssertion so StringAssertion can still use them:
Some changes regarding generic types to remove related warnings have been added as well.
Type of change
Please delete options that are not relevant.
Checklist: