Fix/imap connector delete message #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 11, 2024 14:23
…nd MailConnectorTest; removed deprecated methods in AbstractInboxConnector; marked waitForMails and moveMessage as deprecated in AbstractInboxConnector; changed return value of getMessageCount from long to int in AbstractInboxConnector; corrected handling of boolean return value in pDeleteMessage added usage of PROPERTY_MANAGER in MailConnectorTest, ImapMailConnector and POP3MailConnector; collapsed catches in ImapMailConnector; removed Loggable in ImapMailConnector; changed dataProvider return value in MailConnectorTest; added usage of returned boolean from deleteMessage in MailConnectorTests; removed AssertUtils in MailConnectorTest; corrected testT11_deleteAllMessages in MailConnectorTest; added usage of query method from AbstractInboxConnector in waitForMessage in MailConnectorTest;
…/imap-connector-delete-message � Conflicts: � mail-connector/src/test/java/eu/tsystems/mms/tic/testframework/mailconnector/test/MailConnectorTest.java
clemensgrosse
requested review from
mreiche,
martingrossmann,
gogro,
mbeuthan and
wolamms
as code owners
|
Please recheck the mail connector docs if there is needed an update. |
| @@ -40,8 +41,9 @@ public class EmailQuery { | |||
| */ | |||
| private static final String MAX_READ_TRIES_PROPERTY = "MAX_READ_TRIES"; | |||
|
|
|||
| private int retryCount = Integer.parseInt(PropertyManager.getProperty(MAX_READ_TRIES_PROPERTY, "20")); | |||
| private long pauseMs = Integer.parseInt(PropertyManager.getProperty(POLLING_TIMER_SECONDS_PROPERTY, "10")) * 1000; | |||
| private int retryCount = Integer.parseInt(PROPERTY_MANAGER.getProperty(MAX_READ_TRIES_PROPERTY, "20")); | |||
There was a problem hiding this comment.
Please use PROPERTY_MANAGER.getLongProperty(...)
| @@ -609,7 +530,8 @@ private boolean pDeleteMessage(final SearchTerm searchTerm, final String folderN | |||
| messages = folder.getMessages(); | |||
| } | |||
|
|
|||
| log().info("Checking messages from " + getInboxFolder() + " for MessageID:"); | |||
| final String logMessageSearchTerm = String.format("Checking messages from '%s' for MessageID: '%s'", getInboxFolder(), searchTerm); | |||
| log().info(logMessageSearchTerm); | |||
There was a problem hiding this comment.
Please use default logging syntax with {}, e.g. log().info("Checking messages from {}", getInboxFolder())
...c/main/java/eu/tsystems/mms/tic/testframework/mailconnector/util/AbstractInboxConnector.java
Show resolved
Hide resolved
martingrossmann
requested changes
Jan 12, 2024
...or/src/test/java/eu/tsystems/mms/tic/testframework/mailconnector/test/MailConnectorTest.java
Outdated
Show resolved
Hide resolved
added 2 commits
January 12, 2024 12:01
marked deleteMessage deprecated in AbstractInboxConnector; corrected reading long property in EmailQuery; added usage of deleteAllMessages() in MailConnectorTest; reworked waitForMessage in MailConnectorTest;
| @@ -42,7 +42,7 @@ public class EmailQuery implements PropertyManagerProvider { | |||
| private static final String MAX_READ_TRIES_PROPERTY = "MAX_READ_TRIES"; | |||
|
|
|||
| private int retryCount = Integer.parseInt(PROPERTY_MANAGER.getProperty(MAX_READ_TRIES_PROPERTY, "20")); | |||
| private long pauseMs = Integer.parseInt(PROPERTY_MANAGER.getProperty(POLLING_TIMER_SECONDS_PROPERTY, "10")) * 1000L; | |||
| private long pauseMs = PROPERTY_MANAGER.getLongProperty(POLLING_TIMER_SECONDS_PROPERTY, "10") * 1000; | |||
There was a problem hiding this comment.
Default value should not "10", but 10L
mbeuthan
previously approved these changes
Jan 15, 2024
martingrossmann
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Please delete options that are not relevant.
Checklist: