Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mail connector read message contents #372

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

TobiasAdler
Copy link
Collaborator

Description

When an Email object was created, it was possible that a NullPointerException could be thrown, if the disposition of a part of this multipart message was unknown. The if-Statement for the distinction of the part (either INLINE or ATTACHMENT) was replaced to work reliably, even if the disposition is unknown. In addition some typos in MailConnectorTest were fixed.

Fixes #371

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@martingrossmann
Copy link
Contributor

@TobiasAdler Looks good for me. Please validate that solution with mails generated from different mail clients.

@TobiasAdler
Copy link
Collaborator Author

@martingrossmann The solution was tested successfully, with and without attachments, with multiple different mail clients, including Microsoft Outlook (native & web app), Gmail (mobile & web app) and Thunderbird. All of these mails could be queried without any problems and all contents of these mails, the message itself as well as all attachments, were intact and could be saved and verified with the available methods.

@martingrossmann martingrossmann merged commit c081f0e into master Nov 28, 2023
@martingrossmann martingrossmann deleted the fix/mail-connector_readMessageContents branch November 28, 2023 11:23
@martingrossmann martingrossmann restored the fix/mail-connector_readMessageContents branch November 28, 2023 11:23
@martingrossmann martingrossmann deleted the fix/mail-connector_readMessageContents branch November 28, 2023 11:30
@martingrossmann martingrossmann added this to the 2.7 milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException in Email using ImapMailConnector
2 participants