Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use escaped path in report-ng when accessing JAR #37

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Use escaped path in report-ng when accessing JAR #37

merged 1 commit into from
Apr 29, 2021

Conversation

arbu
Copy link
Contributor

@arbu arbu commented Apr 29, 2021

Description

Previously the URI to the JAR file of report-ng was constructed using the unescaped path. This would fail if there are carecters in the path that are not valid in the path component of a URI (e.g. spaces). This pull request changes the construction of the URI to use the escaped path component and makes report-ng work with local maven repos that have spaces and other
special characters in their path.

Fixes #33

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Tested on Windows in Git Bash and on Ubuntu 20.04.

makes report-ng work with local maven repos that have spaces and other
special characters in their path (fixes #33)
@mreiche mreiche merged commit c48ea51 into telekom:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report generation fails, if path to local maven repository contains spaces
3 participants