Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/uielement highlighter #341

Merged
merged 11 commits into from
Aug 15, 2023
Merged

Conversation

martingrossmann
Copy link
Contributor

Description

Added the possiblity to implement an own UiElement highlighter with a custom JS script.

  • highlight method was moved to interface UiElementHighlighter, JS script is loaded via DefaultUiElementHighlighter. The deprecated method highlightWebelement was finally removed.
  • Some JS methods for click and hover WebElements were finally moved to DesktopWebDriverUtils like documented. JSUtils should only a utility class to make it easier to execute JS snippets, not more.
  • Open (should be handled in an extra PR): some methods in JSUtils can be removed (not documented) or can be moved to DesktopWebDriverUtils.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

# Conflicts:
#	integration-tests/src/test/java/io/testerra/test/status/CheckTestStatusTest.java
@martingrossmann martingrossmann merged commit b1e073b into master Aug 15, 2023
@martingrossmann martingrossmann deleted the feature/uielement-highlighter branch August 15, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant