Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Protobuf library #338

Merged
merged 6 commits into from
Jul 18, 2023
Merged

Update Protobuf library #338

merged 6 commits into from
Jul 18, 2023

Conversation

conradstrassburger
Copy link
Contributor

Description

Changes library that generates TS code from Proto models from protobufjs to ts-proto.
Reduces amount of generated code in general

Fixes #333

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

conradstrassburger
conradstrassburger commented Jul 6, 2023
View reviewed changes
report-ng/app/src/services/framework_pb.ts Outdated
/**
* INFO - info status, not representative
*
* @deprecated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: @deprecated now shows up, along with all other comments from the .proto source.

@martingrossmann martingrossmann mentioned this pull request Jul 10, 2023
Closed
@martingrossmann
Copy link
Contributor

@conradstrassburger Github shows some merge conflicts. Please, can you have a look?

@martingrossmann martingrossmann merged commit a69f74d into telekom:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martingrossmann martingrossmann martingrossmann approved these changes

@mreiche mreiche Awaiting requested review from mreiche mreiche is a code owner

@gogro gogro Awaiting requested review from gogro

@mbeuthan mbeuthan Awaiting requested review from mbeuthan mbeuthan is a code owner

@wolamms wolamms Awaiting requested review from wolamms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Protobuf library
2 participants
@conradstrassburger @martingrossmann