Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/layoutcheck distance image writing #328

Merged
merged 6 commits into from
Jul 18, 2023

Conversation

martingrossmann
Copy link
Contributor

@martingrossmann martingrossmann commented Jun 12, 2023

Description

Executing a test with gradle -p <subproject-dir> test causes a mismatch of the working directory. It is still the project root dir but the subdirectory is needed.
org.apache.commons.io.FileUtil.FileUtils can handle this, but not ImageIO. This was the only place in the code where images were not stored in a temporary directory.

I also fixed the check of image dimensions which causes multiple optional assertions in the report.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@martingrossmann martingrossmann marked this pull request as draft June 12, 2023 08:46
@martingrossmann martingrossmann marked this pull request as ready for review June 30, 2023 14:47
@martingrossmann martingrossmann merged commit f18c05e into master Jul 18, 2023
@martingrossmann martingrossmann deleted the fix/layoutcheck-distance-image-writing branch July 18, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant