Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added try/catch when custom retry analyzers are executed #326

Merged
merged 3 commits into from
May 31, 2023

Conversation

martingrossmann
Copy link
Contributor

Description

Exception in a custom retry analyzer are not catched. Therefor the method context cannot finalized which has impact to the result of a test method.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

mbeuthan
mbeuthan previously approved these changes May 17, 2023
@martingrossmann martingrossmann merged commit 56f7612 into master May 31, 2023
@martingrossmann martingrossmann deleted the fix/npe-at-retry-analyzer branch May 31, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants