Feature/layout check improvement #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasAdler
requested review from
mreiche,
martingrossmann,
gogro and
mbeuthan
as code owners
|
|
||
| A layout test with the Testerra utilities is actually a comparison between a reference and the actual state. This is done via the screenshot functionality of Selenium, in which both screenshots (reference and actual) are compared pixel by pixel from top to bottom. In this comparison, a third image is created in which differences (ReferencePixel != ActualPixel) are marked in red. | ||
|
|
||
| In case that one image is a different size than the other an <<#_optional_assertions, Optional assertion>> fails, so that an error with the information about the different sizes is displayed in the report but the Layout test will still be fully executed. Testerra then considers only the common pixels of both images as 100%. Pixels that are outside of one or the other image are not included in the error calculation. In the comparison, those Pixels are marked in blue. |
There was a problem hiding this comment.
Typo: ... that one image [has] a different size...
There was a problem hiding this comment.
I suggest to shorten that chapter:
... than the other [Testerra reports this as an <<#_optional_assertions, optional assertion>>. Testerra considers only the common]...
martingrossmann
approved these changes
Mar 20, 2023
mbeuthan
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains changes to the error claculation of the layout check feature and some changes to the layout check section of current documentation.
Type of change
Please delete options that are not relevant.
Checklist: