Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added html escape to logline view #300

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Conversation

sbke-mms
Copy link
Collaborator

@sbke-mms sbke-mms commented Jan 4, 2023

Description

Previously any xml that was logged wasn't visible in the log view. This change converts special characters that are reserved for use in HTML to their respective entities so the browser doesn't try to interpret the xml

Fixes # (issue) - no issue had previously been created.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@martingrossmann martingrossmann merged commit 3e2c4a3 into master Jan 6, 2023
@martingrossmann martingrossmann deleted the fix/display-xml-in-log branch January 6, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants