Fixed test status of optional in dataprovider test

[martingrossmann]

Description

In case of optional assertions a testmethod was set to status SKIPPED if the test was part of a dataprovider run.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[Zsar]

Would not anyMatch work just as well here? Or must we discard results after the first?
(value is unused, so we do not actually need a find operation.)

[martingrossmann]

It does not work without value: () -> log().info(...) --> IntelliJ: Cannot infer functional interface type

[martingrossmann]

And it's just a helper class for tests. ;-)

[Zsar]

I mean like this:

if (foundEntries.stream().anyMatch(line -> line.contains(expectedStatus.title))) {
  log().info("Found status {}", expectedStatus.title);
}
else {
  Assert.fail(String.format("'%s' should have status '%s'", methodNameSlug, expectedStatus));
}

?
value is unused in ifPresentOrElse, so we do not actually need a result item.

[Zsar]

(Or alternatively: Did you forget to output value in the ifPresent part?)

[martingrossmann]

Because of unique combination of class and method I have one result or nothing.

And value is not needed in output, I dont want to log the whole line. But value must be declared.

[Zsar]

I mean like this:

if (foundEntries.stream().anyMatch(line -> line.contains(expectedStatus.title))) {
  log().info("Found status {}", expectedStatus.title);
}
else {
  Assert.fail(String.format("'%s' should have status '%s'", methodNameSlug, expectedStatus));
}

?
value is unused in ifPresentOrElse, so we do not actually need a result item.