Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show message for failed validation in expected fails #246

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

sbke-mms
Copy link
Collaborator

Description

Added the validator to the Mapping of the Fails annotation for the report and display it on failed test cases when the validation for the expected failure fails as well. This will also hide the description of the expected failure and the corresponding ticket string if they exist.

Fixes #175

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sbke-mms
Copy link
Collaborator Author

@martingrossmann how should testing be handled here. It would be easy to add something to the ExpectedFailsTests but the resulting report will obviously change and the result needs to be checked there.

@martingrossmann
Copy link
Contributor

@martingrossmann how should testing be handled here. It would be easy to add something to the ExpectedFailsTests but the resulting report will obviously change and the result needs to be checked there.

Corresponding tests should handled by ReportNG tests (https://github.com/telekom/testerra/tree/feature/reportng-tests)

@martingrossmann martingrossmann merged commit 74cbe23 into master Jun 28, 2022
@martingrossmann martingrossmann deleted the feature/expected_failed_validator_message branch June 28, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Report] Fails validator: Add user hints to report
3 participants