Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/screen resolution #15

Merged
merged 5 commits into from
Sep 2, 2021
Merged

Conversation

mreiche
Copy link
Collaborator

@mreiche mreiche commented Sep 2, 2021

Description

Fixes #14

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

gogro
gogro previously approved these changes Sep 2, 2021
@martingrossmann
Copy link
Contributor

martingrossmann commented Sep 2, 2021

@mreiche Please update README.md to note that screenResolution of browser container is releated to Testerra setting tt.window.size, maybe under Additional information.

Update: And please update the version matrix. The next selenoid connector version will be 1.4.

@martingrossmann martingrossmann merged commit f6cad07 into master Sep 2, 2021
@martingrossmann martingrossmann deleted the feature/screen-resolution branch September 2, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window recording is clipped
3 participants