Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/911 sem wait time measures #915

Merged
merged 5 commits into from
May 18, 2015

Conversation

kzangeli
Copy link
Member

Implements #911

Added the accumulated waiting time on database semaphores to the statistics information for the REST service /statistics.
However, this new feature is enabled only if the broker is started with the new CLI parameter
-mutexTimeStat

@@ -83,6 +96,42 @@ int semInit(SemRequestType _reqPolicy, int shared, int takenInitially)

/* ****************************************************************************
*
* difftimeofday -
*/
static void difftimeofday(struct timespec* endTime, struct timespec* startTime, struct timespec* diffTime)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calmeCase should be diffTimeOfDay

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name was picked this way because of the standard C library function 'gettimeofday'.
The name 'difftimeofday' shows that it is related to 'gettimeofday' ...

However, after creating these functions I realized gettimeofday wasn't good enough as it only gives microsconds. I found another function instead, clock_gettime, and after this change, the name difftimeofday no longer makes any sense.

Changing it for clock_difftime (and clock_addtime)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 7cccbfb

@fgalan
Copy link
Member

fgalan commented May 18, 2015

LGTM

fgalan pushed a commit that referenced this pull request May 18, 2015
…easures

Feature/911 sem wait time measures
@fgalan fgalan merged commit ae7883e into develop May 18, 2015
@fgalan fgalan deleted the feature/911_sem_wait_time_measures branch May 18, 2015 08:00
fisuda pushed a commit to fisuda/fiware-orion that referenced this pull request Feb 15, 2022
Fixed issue telefonicaid#914: double @context member for GET /attributes?details=…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants