-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1677 ngsi2 geoqueries as payload scope #1828
Feature/1677 ngsi2 geoqueries as payload scope #1828
Conversation
} | ||
} | ||
EOF | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If remark about that "coords" needs to be provided before "geometry" should be included in the documentation in this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, only, coords needs to go after geometry.
I got the impression you would add this to the documentation. Perhaps I'm confusing this with something else ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You or me, it doesn't matter ;)
I'm suggesting you doing it as the PR is "hot under your fingers" (I'm now working in another piece of code), but as you prefer...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 94c5d18
EOF | ||
``` | ||
|
||
Please note that the 'coords' field of the complex value of the scope needs to be put **after** the field 'geometry'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For literal citing fields, we typically used code-style, i.e. using coords
instead of 'coords' (the same for geometry).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in c0183d1
LGTM (passing the ball to @crbrox for final LGTM + merge + delete branch) |
LGTM |
…ies_as_payload_scope Feature/1677 ngsi2 geoqueries as payload scope
Implements #1677
NGSIv2 geo-queries now also possible in V1, as part of JSON payload