Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1677 ngsi2 geoqueries as payload scope #1828

Merged
merged 6 commits into from
Feb 23, 2016

Conversation

kzangeli
Copy link
Member

Implements #1677

NGSIv2 geo-queries now also possible in V1, as part of JSON payload

@kzangeli kzangeli added this to the 0.28.0 milestone Feb 23, 2016
}
}
EOF
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If remark about that "coords" needs to be provided before "geometry" should be included in the documentation in this section.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, only, coords needs to go after geometry.
I got the impression you would add this to the documentation. Perhaps I'm confusing this with something else ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You or me, it doesn't matter ;)

I'm suggesting you doing it as the PR is "hot under your fingers" (I'm now working in another piece of code), but as you prefer...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 94c5d18

EOF
```

Please note that the 'coords' field of the complex value of the scope needs to be put **after** the field 'geometry'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For literal citing fields, we typically used code-style, i.e. using coords instead of 'coords' (the same for geometry).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in c0183d1

@fgalan
Copy link
Member

fgalan commented Feb 23, 2016

LGTM (passing the ball to @crbrox for final LGTM + merge + delete branch)

@crbrox
Copy link
Member

crbrox commented Feb 23, 2016

LGTM

crbrox added a commit that referenced this pull request Feb 23, 2016
…ies_as_payload_scope

Feature/1677 ngsi2 geoqueries as payload scope
@crbrox crbrox merged commit 2066f2f into develop Feb 23, 2016
@crbrox crbrox deleted the feature/1677_ngsi2_geoqueries_as_payload_scope branch February 23, 2016 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants