As cmd/{bash,nop,gsutil} image are gone, removing them from plumbing ⛏
#104
Conversation
|
@vdemeester: GitHub didn't allow me to request PR reviews from the following users: ImJasonH. Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
size/XS
prow/config.yaml
Outdated
| @@ -1216,9 +1216,6 @@ periodics: | |||
| - name: builtNopImage | |||
| resourceRef: | |||
| name: nop-image | |||
| - name: builtBashImage | |||
| resourceRef: | |||
| name: bash-image | |||
| - name: builtGsutilImage | |||
There was a problem hiding this comment.
The gsutil image was also removed in tektoncd/pipeline#1504 -- sorry for missing both of these!
|
And cmd/nop too: tektoncd/pipeline#1510 That's the last one for now though, I promise. |
See tektoncd/pipeline#1503. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
cmd-bash-is-gone
branch
from
9ba0f58 to
9b63ee8
Compare
tekton-robot
added
size/S
vdemeester
changed the title
cmd/bash image is gone, removing it from plumbing ⛏cmd/{bash,nop,gsutil} image are gone, removing them from plumbing ⛏
|
/lgtm |
|
@imjasonh: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
There was a problem hiding this comment.
This is an interesting use case to see actually. Since pipeline interface changed on pipeline, this is now broken. The release still works until we manually apply the changes, but once we have CD in place we will have to find ways to make changes so that we don't break.
Being able to refer to a task via URL/ref would definitely help here.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
See tektoncd/pipeline#1503.
Signed-off-by: Vincent Demeester [email protected]
/cc @afrittoli @imjasonh
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.