Minor style nits affecting YAML output

[imjasonh]

Changes

Address some minor styling nits affecting YAML output.

• Add omitempty for string, slice, map or pointer fields that can be omitted.
• Remove omitempty from non-pointer struct fields, where omitempty doesn't do anything.

From encoding/json:

The "omitempty" option specifies that the field should be omitted from the encoding if the field has an empty value, defined as false, 0, a nil pointer, a nil interface value, and any empty array, slice, map, or string.

In addition to this change, some fields that are structs could be changed to pointers, to allow them to be omitted from YAML output as well, when not specified.

For example, TaskRunSpec's Outputs field is an Outputs struct, which means the field is always present in YAML output, but is outputs: {} when none are specified. If the field was a *Outputs with json:"outputs,omitempty, it could be omitted from YAML if none are specified. Same with TaskRunSpec's Inputs and Trigger fields, and some in PipelineRunSpec, etc.

It's possible that outputs: {} is preferrable to just omitting it, but it's unclear whether that was an explicit decision or not. 🤷‍♂️

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• [ 🙅‍♂️] Includes tests (if functionality changed/added)
• [ 🙅‍♂️] Includes docs (if user facing)
• [ 🙅‍♂️] Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

N/A

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ImJasonH]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bobcatfish]

It's possible that outputs: {} is preferrable to just omitting it, but it's unclear whether that was an explicit decision or not. 🤷‍♂️

No I don't think this was intentional! Should be a pointer from what I can tell 😅

[bobcatfish]

Thanks for the cleanup @imjasonh !! ❤️ 🎉 💃

/lgtm
/meow space

[tekton-robot]

@bobcatfish:

In response to this:

Thanks for the cleanup @imjasonh !! ❤️ 🎉 💃

/lgtm
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.