config: prefixes image names with ko:// scheme

[poy]

Changes

Prefixes image names with ko:// scheme. This allows ko to improve the experience with Go modules. See ko-build/ko#58 for more information.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

[tekton-robot]

Hi @poy. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vdemeester]

Prefixes image names with ko:// scheme. This allows ko to improve the experience with Go modules. See google/ko#58 for more information.

I am interested into know how it improves the experience 👼.

[vdemeester]

Shouldn't thoses (all starting with github.com/tektoncd/pipeline) also be prefixed ?

[imjasonh]

/ok-to-test

The improvement is from making typos less difficult to debug.

[vdemeester]

@imjasonh could there be a strict way with this, as : in a "strict mode" you would get an error if a ko:// reference is missing from what ko gathered to build the image for. Would it be possible to have that ? (because otherwise, it will fail silently, right ? and will have an ErrPull… on the pod(s))

[imjasonh]

If I'm understanding, yes that's exactly what ko does with this prefix. If it sees the special prefix in normal mode it strips it (for recent versions of ko in the last 6? months). If you pass --strict then it strips the ko:// prefix and fails if the import path isn't recognized, instead of passing it through, which leads to unpullable image references.

This is step one to adopting ko strict more. After this we can run ko with --strict to avoid bad refs.

[vdemeester]

If I'm understanding, yes that's exactly what ko does with this prefix. If it sees the special prefix in normal mode it strips it (for recent versions of ko in the last 6? months). If you pass --strict then it strips the ko:// prefix and fails if the import path isn't recognized, instead of passing it through, which leads to unpullable image references.

This is step one to adopting ko strict more. After this we can run ko with --strict to avoid bad refs.

Alright, if it works like this, it sounds good to me 👍
/lgtm

/cc @afrittoli @bobcatfish

[dibyom]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vdemeester]

/hold

[vdemeester]

https://github.com/tektoncd/pipeline/pull/2216/files/f7442117ba4f54a884173bebb06ff542e7bc6ffe#diff-d56e306ce931c2991f18ef68b6b501a3 needs to be taken into account 👼

[vdemeester]

/test pull-tekton-pipeline-integration-tests

[vdemeester]

/hold cancel
I'll follow-up on this

[vdemeester]

/test pull-tekton-pipeline-integration-tests