Bump knative.dev/pkg to 528ad1c 🔥 #1412
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XXL
vdemeester
force-pushed
the
bump-knative
branch
from
2dc0597 to
88d97e9
Compare
This brings some change on how to create the webhook, alongside import change related to the injection packages. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
bump-knative
branch
from
88d97e9 to
7b41d74
Compare
|
/hold |
tekton-robot
added
the
do-not-merge/hold
|
/cc @afrittoli @abayer |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Will remove the hold once 0.8 is released 😉 |
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
| } | ||
| //TODO add validations here |
There was a problem hiding this comment.
Do we need to lose this comment?
There was a problem hiding this comment.
So I removed it because we are already doing validation in the webhook, so I felt it wasn't necessary anymore.
| v1alpha1.SchemeGroupVersion.WithKind("Condition"): &v1alpha1.Condition{}, | ||
| } | ||
|
|
||
| resourceAdmissionController := webhook.NewResourceAdmissionController(resourceHandlers, options, true) |
There was a problem hiding this comment.
NIT: The third parameter here is the "DisallowUnknownFields" - but to know that one has to lookup the NewResourceAdmissionController code, so I think we lose a bit in readability.
There was a problem hiding this comment.
@afrittoli I agree 😅 We should either name that boolean or propose some changes upstream to make the New… more "functionnal".
Changes
This brings some change on how to create the webhook, alongside import
change related to the injection packages.
One of the reason to do that, is to be able to update the k8s dependency in a cleaner way 👼 (otherwise it's gonna be hell to review I think 😅 )
Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.