Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for optional workspaces in tkn start #1377

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

vinamra28
Copy link
Member

Changes

As of now if the resource contains an optional workspace we still have
to bind the corresponding workspace value at the time of doing tkn <resource> start.

With this commit, it will ask interactively whether we want to provide
details for workspace or not if it's optional.
Added e2e tests for the same.

Signed-off-by: vinamra28 [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Ask whether to provide specifications for the optional workspace at the time of doing tkn <resource> start

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 27, 2021
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 27, 2021
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipeline/start.go 66.2% 65.3% -0.9

@vinamra28 vinamra28 force-pushed the fix-optional-workspace branch from f4f0cec to 9898af0 Compare May 27, 2021 13:15
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipeline/start.go 66.2% 65.3% -0.9

@vinamra28
Copy link
Member Author

/retest

@vinamra28 vinamra28 force-pushed the fix-optional-workspace branch from 9898af0 to b2716eb Compare May 27, 2021 14:03
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipeline/start.go 66.2% 65.3% -0.9

@vinamra28 vinamra28 force-pushed the fix-optional-workspace branch from b2716eb to b0781ab Compare May 29, 2021 11:28
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipeline/start.go 66.2% 65.3% -0.9

@vinamra28 vinamra28 force-pushed the fix-optional-workspace branch from b0781ab to 86c72d5 Compare May 29, 2021 18:25
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipeline/start.go 66.2% 65.3% -0.9

@vinamra28
Copy link
Member Author

/retest

1 similar comment
@vinamra28
Copy link
Member Author

/retest

Copy link
Member

@chmouel chmouel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Looking Good! 🤙🏽

pkg/cmd/pipeline/start.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2021
As of now if the resource contains an optional workspace we still have
to bind the corresponding workspace value at the time of doing tkn
<resource> start.

With this commit, it will ask interactively whether we want to provide
details for workspace or not if it's optional.
Added e2e tests for the same.

Signed-off-by: vinamra28 <[email protected]>
@vinamra28 vinamra28 force-pushed the fix-optional-workspace branch from 86c72d5 to 4ee9f80 Compare May 31, 2021 07:40
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 31, 2021
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipeline/start.go 66.2% 65.3% -0.9

@vinamra28
Copy link
Member Author

/retest

@chmouel
Copy link
Member

chmouel commented May 31, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2021
@piyush-garg
Copy link
Contributor

/approve
/lgtm

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021
@chmouel
Copy link
Member

chmouel commented Jun 2, 2021

/lgtm
/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chmouel,piyush-garg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@piyush-garg
Copy link
Contributor

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants