-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for optional workspaces in tkn start #1377
Conversation
The following is the coverage report on the affected files.
|
f4f0cec
to
9898af0
Compare
The following is the coverage report on the affected files.
|
/retest |
9898af0
to
b2716eb
Compare
The following is the coverage report on the affected files.
|
b2716eb
to
b0781ab
Compare
The following is the coverage report on the affected files.
|
b0781ab
to
86c72d5
Compare
The following is the coverage report on the affected files.
|
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Looking Good! 🤙🏽
As of now if the resource contains an optional workspace we still have to bind the corresponding workspace value at the time of doing tkn <resource> start. With this commit, it will ask interactively whether we want to provide details for workspace or not if it's optional. Added e2e tests for the same. Signed-off-by: vinamra28 <[email protected]>
86c72d5
to
4ee9f80
Compare
The following is the coverage report on the affected files.
|
/retest |
/lgtm |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, piyush-garg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Changes
As of now if the resource contains an optional workspace we still have
to bind the corresponding workspace value at the time of doing
tkn <resource> start
.With this commit, it will ask interactively whether we want to provide
details for workspace or not if it's optional.
Added e2e tests for the same.
Signed-off-by: vinamra28 [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
See the contribution guide
for more details.
Release Notes