Fix error message if no supported package manager found #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrix
requested review from
psss,
lukaszachy,
happz and
janhavlin
as code owners
happz
reviewed
Apr 4, 2024
happz
added
step | prepare
lukaszachy
previously requested changes
Apr 23, 2024
happz
force-pushed
the
error-unknown-package-manager
branch
from
f232962 to
9f8f00d
Compare
happz
approved these changes
Apr 30, 2024
therazix
approved these changes
Apr 30, 2024
psss
approved these changes
May 3, 2024
psss
force-pushed
the
error-unknown-package-manager
branch
from
9f8f00d to
1f25e66
Compare
``` Unrecognized package manager. ``` Or: ``` Package manager 'foo' is not supported by 'prepare/install'. ``` when the package manager has been detected, but is not supported by `prepare/install`. I like this error more than: ``` 'Package manager "None" is not supported.' ``` Signed-off-by: Miroslav Vadkerti <[email protected]>
psss
force-pushed
the
error-unknown-package-manager
branch
from
1f25e66 to
a94a9ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or:
when the package manager has been detected, but is not supported by
prepare/install.I like this error more than:
Pull Request Checklist