-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish prepare/ansible documentation #2824
Conversation
looks good to me |
5683d6c
to
91793bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thanks! Just two nitpicks.
Includes added pyright cover, two birds with one stone.
f9496fd
to
ff08000
Compare
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs look good to me, just a semi-related question - Shouldn't tmt have ansible as a dependency in some form? afaik, it will only be installed as part of provision-virtual or provision-container optional extras packages. Then there is the PyPI package.
Maybe at least it should be mentioned in the docs with "make sure you have ansible installed" or something
Good point! The cleanest way would probably be to require |
And |
Test failures are irrelevant --> merging. |
Includes added pyright cover, two birds with one stone.
Pull Request Checklist