Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when the workdir of runs doesn't exist #2805

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented Apr 2, 2024

Pull Request Checklist

  • implement the feature

@skycastlelily
Copy link
Collaborator Author

fix the confusing problem reported in:#2772

@skycastlelily
Copy link
Collaborator Author

skycastlelily commented Apr 2, 2024 via email

@martinhoyer martinhoyer added this to the 1.41 milestone Dec 13, 2024
@seberm seberm added the code | utils Various utility functions and classes used across the code label Dec 13, 2024
@skycastlelily skycastlelily added the ci | full test Pull request is ready for the full test execution label Dec 17, 2024
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jan 3, 2025
@psss psss requested a review from martinhoyer as a code owner January 9, 2025 13:27
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just fixed the unfinished error message in 096899d.

@psss psss changed the title Raise error when the workdir of runs doesn't exit Raise error when the workdir of runs doesn't exist Jan 9, 2025
@psss psss merged commit f558779 into teemtee:main Jan 9, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution code | utils Various utility functions and classes used across the code status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants