-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error when the workdir of runs doesn't exist #2805
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the confusing problem reported in:#2772 |
happz
reviewed
Apr 2, 2024
Ah, yes,I was thinking raise error when I work on the commit,then I
changed my idea(warn may be enough),but I forgot change the commit
message,updated^^
…On Tue, Apr 2, 2024 at 10:55 PM Miloš Prchlík ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tmt/base.py
<#2805 (comment)>:
> @@ -3810,7 +3810,12 @@ def guests(self) -> bool:
self.info('guests', color='blue')
root_path = Path(self.opt('workdir-root'))
# FIXME: cast() - typeless "dispatcher" method
- id_ = cast(str, self.opt('id_'))
+ id_ = tmt.utils.Config().last_run if self.opt('last') else cast(str, self.opt('id_'))
+ if id_ and not (root_path / Path(id_).name).exists():
+ self.warn(
+ f"Directory '{root_path / Path(id_).name}' does not exist, "
+ f"skipping guest cleanup.")
+
Nothing seems to be skipped, a warning is emitted but the code continues
on the next line.
—
Reply to this email directly, view it on GitHub
<#2805 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFR23AMNWEYW4CBOG6HPDTY3LBFTAVCNFSM6AAAAABFTPF7TGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZUGA4TINZYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
4d9a28f
to
53e8826
Compare
53e8826
to
635c6ae
Compare
635c6ae
to
07cced7
Compare
therazix
approved these changes
Dec 17, 2024
happz
approved these changes
Jan 3, 2025
psss
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just fixed the unfinished error message in 096899d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci | full test
Pull request is ready for the full test execution
code | utils
Various utility functions and classes used across the code
status | ready for merge
The only missing piece is to do the rebase the current 'main' and let the CI finish.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist