Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper support for the duration format #1972

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Proper support for the duration format #1972

merged 1 commit into from
Apr 14, 2023

Conversation

lukaszachy
Copy link
Collaborator

@lukaszachy lukaszachy commented Apr 4, 2023 •
edited
Loading

We claim to support same format as sleep commands so let's actually do it.

  • implement the feature
  • extend the test coverage
  • update specification
  • modify json schema

@lukaszachy lukaszachy requested review from psss and FrNecas as code owners April 4, 2023 13:08
@lukaszachy lukaszachy requested a review from happz April 4, 2023 14:02
@psss psss requested a review from thrix as a code owner April 4, 2023 14:31
psss
psss requested changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we just need to extend the schema as well:

warn: /tests/core/smoke:duration - '1s 2s' does not match '^[0-9]+[smhd]$'

Proposing also a minor docs enhancement in 4a3ef75.

@psss psss changed the title Proper support for duration format Proper support for duration format Apr 5, 2023
@psss psss changed the title Proper support for duration format Proper support for the duration format Apr 5, 2023
@psss psss added specification Metadata specification (core, tests, plans, stories) command | tests tmt tests command labels Apr 5, 2023
KwisatzHaderach
KwisatzHaderach reviewed Apr 5, 2023
View reviewed changes
@psss psss self-assigned this Apr 13, 2023
@psss psss added this to the 1.22 milestone Apr 13, 2023
psss
psss approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice fix & improvement! Spec example simplified in 16dc695.

@lukaszachy @psss
Proper support for the test duration format
748125d 
We claim to support same format as `sleep` commands so let's
actually do it.

Co-authored-by: Petr Šplíchal <[email protected]>
@psss psss force-pushed the duration-more-values-with-spaces branch from 16dc695 to 748125d Compare April 13, 2023 21:49
@psss psss merged commit 748125d into main Apr 14, 2023
@psss psss deleted the duration-more-values-with-spaces branch April 14, 2023 05:26
@psss psss mentioned this pull request Apr 17, 2023
Closed
@psss psss mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@psss psss psss approved these changes

@FrNecas FrNecas Awaiting requested review from FrNecas

@thrix thrix Awaiting requested review from thrix thrix is a code owner

Assignees

@psss psss

Labels
command | tests tmt tests command specification Metadata specification (core, tests, plans, stories)
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@lukaszachy @happz @KwisatzHaderach @psss