MINOR: Fix typo and refactor new group coordinator tests (apache#17072)

This patch fixes a few things: * Typos. * Merge the tests for fetchOffsets and fetchAllOffsets together into parameterized tests since they share the same structure. * Use Topic.GROUP_METADATA_TOPIC_NAME instead of __consumer_offsets in new group coordinator tests. Reviewers: Ken Huang <[email protected]>, David Jacot <[email protected]>
tedyu · Jan 6, 2025 · 011c3aa · 011c3aa
1 parent d55747b
commit 011c3aa
Show file tree

Hide file tree

Showing 6 changed files with 111 additions and 202 deletions.
diff --git a/...java/org/apache/kafka/coordinator/common/runtime/CoordinatorOperationExceptionHelper.java b/...java/org/apache/kafka/coordinator/common/runtime/CoordinatorOperationExceptionHelper.java
@@ -27,7 +27,7 @@
 public class CoordinatorOperationExceptionHelper {
     /**
      * This is the handler commonly used by all the operations that requires to convert errors to
-     * coordinator errors. The handler also handles and log unexpected errors.
+     * coordinator errors. The handler also handles and logs unexpected errors.
      *
      * @param operationName     The name of the operation.
      * @param operationInput    The operation's input for logging purposes.

diff --git a/...coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java b/...coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java
@@ -1232,7 +1232,7 @@ private static boolean isGroupIdNotEmpty(String groupId) {
 
     /**
      * This is the handler used by offset fetch operations to convert errors to coordinator errors.
-     * The handler also handles and log unexpected errors.
+     * The handler also handles and logs unexpected errors.
      *
      * @param operationName     The name of the operation.
      * @param request           The OffsetFetchRequestGroup request.