You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 16, 2023. It is now read-only.
I'm using this action to trigger a notification when a deployment workflow fails. In this workflow, a job being skipped always means something went wrong and we should be notified, but this action reports a successful conclusion even when jobs are skipped.
Describe the solution you'd like: 考えうる解決方法
Only report the conclusion as success if all jobs were actually successful.
For backwards compatibility, this behavior could be behind a boolean input variable like strict_success and default to false.
Describe alternatives you've considered: 考えうる代替案
Outputting the list of results for all jobs would also serve my purposes, but I see you already turned down that suggestion in #53. The workaround in your comment there doesn't work for me, because this notification is a reusable job we call from different workflows -- to get each job result myself, I would have to reimplement most of workflow-conclusion-action (which is why I'm requesting it here instead).
Additional context: 補足
If you're open to this feature but don't have time for it, I can try making a PR for it.
The text was updated successfully, but these errors were encountered:
Please describe your suggestion: 提案の概要
I'm using this action to trigger a notification when a deployment workflow fails. In this workflow, a job being skipped always means something went wrong and we should be notified, but this action reports a successful conclusion even when jobs are skipped.
Describe the solution you'd like: 考えうる解決方法
Only report the conclusion as
success
if all jobs were actually successful.For backwards compatibility, this behavior could be behind a boolean input variable like
strict_success
and default to false.Describe alternatives you've considered: 考えうる代替案
Outputting the list of results for all jobs would also serve my purposes, but I see you already turned down that suggestion in #53. The workaround in your comment there doesn't work for me, because this notification is a reusable job we call from different workflows -- to get each job result myself, I would have to reimplement most of
workflow-conclusion-action
(which is why I'm requesting it here instead).Additional context: 補足
If you're open to this feature but don't have time for it, I can try making a PR for it.
The text was updated successfully, but these errors were encountered: