Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(postgres): modify the docker base image as postgres:11-alpine #5

Merged
merged 8 commits into from
Nov 28, 2018
Merged

feat(postgres): modify the docker base image as postgres:11-alpine #5

merged 8 commits into from
Nov 28, 2018

Conversation

duanhongyi
Copy link
Member

@duanhongyi duanhongyi commented Nov 17, 2018 •
edited
Loading

Using postgres:11-alpine instead of the postgres:11, the size is close to the original 1/3.

@duanhongyi duanhongyi changed the title feat(postgres): modify the docker base image as postgres:11-apline feat(postgres): modify the docker base image as postgres:11-alpine Nov 17, 2018
@duanhongyi duanhongyi force-pushed the master branch 3 times, most recently from 1d1d8a0 to e1b0c3b Compare November 17, 2018 23:14
@Cryptophobia
Copy link
Member

Looks good! It's exciting that it's only 1/3 the size of the original postgres image. @duanhongyi , is this ready for review and merge?

@duanhongyi
Copy link
Member Author

Looks good! It's exciting that it's only 1/3 the size of the original postgres image. @duanhongyi , is this ready for review and merge?

yes

till
till suggested changes Nov 19, 2018
View reviewed changes
Copy link

@till till left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly a few questions.

Nice work! The size improvement will be significant!

till
till reviewed Nov 19, 2018
View reviewed changes
till
till approved these changes Nov 19, 2018
View reviewed changes
Copy link

@till till left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for responding to all my questions.

Good to merge, IMO!

This was referenced Nov 24, 2018
Closed
Merged
@duanhongyi duanhongyi force-pushed the master branch 3 times, most recently from 34e3648 to ea21ee1 Compare November 24, 2018 16:21
@kingdonb kingdonb mentioned this pull request Nov 24, 2018
Open
@duanhongyi
Copy link
Member Author

duanhongyi commented Nov 25, 2018 •
edited
Loading

close, see #7

@duanhongyi duanhongyi closed this Nov 25, 2018
@Cryptophobia
Copy link
Member

@duanhongyi , I'm going to reopen merge this PR as it has better history for the approval process.

@Cryptophobia Cryptophobia reopened this Nov 25, 2018
@Cryptophobia
Copy link
Member

Merging this in now and going to build a new tag v2.7.1 so we can make Hephy Workflow v2.20 start up faster @kingdonb @duanhongyi 😁

Cryptophobia
Cryptophobia approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cryptophobia Cryptophobia merged commit 745ca31 into teamhephy:master Nov 28, 2018
@till
Copy link

till commented Nov 28, 2018

Yay!!! :D

@kingdonb kingdonb mentioned this pull request Feb 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@till till till approved these changes

@Cryptophobia Cryptophobia Cryptophobia approved these changes

@kingdonb kingdonb Awaiting requested review from kingdonb

@rwos rwos Awaiting requested review from rwos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duanhongyi @Cryptophobia @till