fix: make samesite and domain attributes configurable for frontend sdk cookie #1251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1245
Fixes #699
Implementation
This PR makes both the SameSite and the Domain attribute configurable in the
frontend-sdk
via options when instantiating the main client instance and via theelements
options whenregister
-ing components.How to test
/etc/hosts
file, e.g. addfrontend/examples/express
files: :server.js
changecorsOptions.origin
fromlocalhost
tomyapp.local
:.env
, changeHANKO_API_URL
to the API URL of a Hanko Cloud instance.frontend/examples/react
files:.env
, changeREACT_APP_HANKO_API
to the API URL of a Hanko Cloud instance andREACT_APP_TODO_API
tohttp://api.myapp.local:8002
.http://myapp.local:8888
.npm run build
in thefrontend
directory.npm run start
for both thefrontend/examples/express
and thefrontend/examples/react
app.options
passed toregister
calls infrontend/examples/react
(i.e. inHankoAuth
/HankoProfile
).Todos/Issues/Questions