-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add React media components #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great examples and Media component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested and the audio is opened(I mean you can hear your voice) before the callee pick up the call.
I got an error when try to run the packages/react-client/example
it is complaining about a different version on babel-jest
, to work around I added this "start": "SKIP_PREFLIGHT_CHECK=true node ../node_modules/react-scripts/bin/react-scripts.js start",
I think you can add this script command "setup": "cp .env.sample .env"
@DeividVeloso I fixed the doubled audio issue by tweaking the UX by adding a checkbox: Could you retest? |
Adds
Media
,Audio
andVideo
components, with examples, toreact-client
.π To Do
β Manual testing
Note: I'm testing with the Telnyx web dialer, but should work in theory with a hardware or softphone, too.
npm run build
inpackages/react-client
cd
intopackages/react-client/example
and runnpm start
π¦ Browser testing
Desktop
πΈ Screenshots