Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React media components #57

Merged
merged 14 commits into from
Nov 18, 2020
Merged

Conversation

SuaYoo
Copy link
Contributor

@SuaYoo SuaYoo commented Nov 11, 2020

Adds Media, Audio and Video components, with examples, to react-client.

πŸ“ To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

βœ‹ Manual testing

Note: I'm testing with the Telnyx web dialer, but should work in theory with a hardware or softphone, too.

  1. Build react-client by running npm run build in packages/react-client
  2. cd into packages/react-client/example and run npm start
  3. Make an audio-only call. Verify that you hear audio coming from the browser
  4. Make a video call. Verify that you see and hear video in the browser

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

πŸ“Έ Screenshots

Screen Shot 2020-11-12 at 12 10 20 PM

@SuaYoo SuaYoo marked this pull request as ready for review November 12, 2020 20:15
Copy link
Contributor

@hugooliveirad hugooliveirad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great examples and Media component

Copy link
Contributor

@DeividVeloso DeividVeloso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and the audio is opened(I mean you can hear your voice) before the callee pick up the call.

I got an error when try to run the packages/react-client/example it is complaining about a different version on babel-jest, to work around I added this "start": "SKIP_PREFLIGHT_CHECK=true node ../node_modules/react-scripts/bin/react-scripts.js start",

I think you can add this script command "setup": "cp .env.sample .env"

@SuaYoo SuaYoo requested a review from DeividVeloso November 17, 2020 23:06
@SuaYoo
Copy link
Contributor Author

SuaYoo commented Nov 17, 2020

I tested and the audio is opened(I mean you can hear your voice) before the callee pick up the call.

@DeividVeloso I fixed the doubled audio issue by tweaking the UX by adding a checkbox:
Screen Shot 2020-11-17 at 3 06 59 PM

Could you retest?

@SuaYoo SuaYoo merged commit 592dfa3 into main Nov 18, 2020
@SuaYoo SuaYoo deleted the WEBRTC-278_Add_audio_video_components branch November 18, 2020 17:29
hugooliveirad pushed a commit that referenced this pull request Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants