Add Call Control and other call ids to call state #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RTC backend is going to send `telnyx_call_control_id`, `telnyx_session_id` and `telnyx_leg_id` params in the `telnyx_rtc.invite` message. We then save it inside the Call object so that it is accessible in upcoming `notification` events. This should enable customers to cross-reference calls between the Call Control backend and the WebRTC client. This commit includes a few fixes to the VertoHandler tests.
hugooliveirad
commented
Oct 19, 2020
| @@ -1,275 +1,413 @@ | |||
| import behaveLikeBaseSession from './behaveLike/BaseSession.spec' | |||
| import VertoHandler from './webrtc/VertoHandler' | |||
There was a problem hiding this comment.
Removed this VertoHandler import
hugooliveirad
commented
Oct 19, 2020
Comment on lines
-22
to
-23
| VertoHandler.call(this, Verto) | ||
| LayoutHandler.call(this, Verto) |
There was a problem hiding this comment.
Removed these calls
hugooliveirad
commented
Oct 19, 2020
Comment on lines
+59
to
+69
| if (params.telnyx_call_control_id) { | ||
| callOptions.telnyxCallControlId = params.telnyx_call_control_id; | ||
| } | ||
|
|
||
| if (params.telnyx_session_id) { | ||
| callOptions.telnyxSessionId = params.telnyx_session_id; | ||
| } | ||
|
|
||
| if (params.telnyx_leg_id) { | ||
| callOptions.telnyxLegId = params.telnyx_leg_id; | ||
| } |
There was a problem hiding this comment.
Code to expose telnyxSessionId and other ids
hugooliveirad
commented
Oct 19, 2020
Comment on lines
+33
to
+36
| // Optional, sent by Telnyx RTC | ||
| telnyxCallControlId?: string; | ||
| telnyxSessionId?: string; | ||
| telnyxLegId?: string; |
There was a problem hiding this comment.
Added options call options from invite
6 tasks
SuaYoo
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RTC backend is going to send
telnyx_call_control_id,telnyx_session_idandtelnyx_leg_idparams in thetelnyx_rtc.invitemessage. We then save it inside the Call object sothat it is accessible in upcoming
notificationevents.This should enable customers to cross-reference calls between the Call
Control backend and the WebRTC client.
This PR includes a few fixes to the VertoHandler tests.
📝 To Do
✋ Manual testing
npm linkin this repositorynpm link @telnyx/webrtcin the repository you will run this code on (e.g. call-center/web-client)rtc.telnyx.commessagestelnyx_rtc.invitemessage params. Confirm it hastelnyx_session_idandtelnyx_leg_id.telnyx_call_control_idto be implemented.telnyxSessionIdandtelnyxLegIdas call options.🦊 Browser testing
Desktop
📸 Screenshots