fix(WEBRTC-746): recursive call to getDevices when the browser does not support audiooutput like Safari and Firefox. #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udiooutput like Safari and Firefox. The issue was happening when the browser does not support audiooutput and it returns device list with empty array when the code received empty device list it was trying to call getUserMedia and getDevices to fullfiled with data, but as the browser does not support it was executing the getDevices method in infinite loop. To solve it we will only execute getDevices in recursion if the device list has data with label and deviceid empty. This means that the browser supports audiooutput but the user does not allowed the permission to access devices yet.
DeividVeloso
changed the title
arghav
approved these changes
Dec 8, 2021
DeividVeloso
force-pushed
the
WEBRTC-746-recursive-getDevices
branch
from
4d125fe to
9128fb6
Compare
DeividVeloso
changed the title
DeividVeloso
force-pushed
the
WEBRTC-746-recursive-getDevices
branch
from
9128fb6 to
71c2c01
Compare
DeividVeloso
force-pushed
the
WEBRTC-746-recursive-getDevices
branch
from
71c2c01 to
451b906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the recursive call to getDevices when the browser does not support audio output like Safari and Firefox.
The issue was happening when the browser does not support audio output and
it returns a device list with an empty array when the code received an empty device list it was trying to call getUserMedia and getDevices to fulfilled with data,
but as the browser does not support audio output it was executing the getDevices method in an infinite loop.
To solve it I removed the recursion of getDevice method and now I'm checking first if the user gave permission to list devices, if yes I return a list of devices with all the data fulfilled else I trigger an error and I return an empty array without any device.
📝 To Do
✋ Manual testing
🦊 Browser testing
Desktop
📸 Screenshots