fix(ENGDESK-11008): asking for permission on the browser when calling methods that require audio output devices #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equire audio output devices
arghav
reviewed
Sep 6, 2021
| @@ -29,7 +29,7 @@ const _constraintsByKind = ( | |||
| kind: string = null | |||
| ): { audio: boolean; video: boolean } => { | |||
| return { | |||
| audio: !kind || kind === DeviceType.AudioIn, | |||
| audio: !kind || kind === DeviceType.AudioIn || kind === DeviceType.AudioOut, | |||
There was a problem hiding this comment.
The SDK is using here getAudioOutDevices, to be able to list the Audio Out Put Devices, for do that we need to add the permission of {audio: true}
There was a problem hiding this comment.
There was a problem hiding this comment.
Okay, just wanted to be sure this was intentional.
arghav
approved these changes
Sep 8, 2021
| @@ -29,7 +29,7 @@ const _constraintsByKind = ( | |||
| kind: string = null | |||
| ): { audio: boolean; video: boolean } => { | |||
| return { | |||
| audio: !kind || kind === DeviceType.AudioIn, | |||
| audio: !kind || kind === DeviceType.AudioIn || kind === DeviceType.AudioOut, | |||
There was a problem hiding this comment.
Okay, just wanted to be sure this was intentional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 To Do
✋ Manual testing
js/examples/react-audio-widgetnpm run setupandnpm run storybookGet output audio devicesbutton and see if will prompt a modal asking for permission.🦊 Browser testing
Desktop
📸 Screenshots